TST Adjust learning rate to compare with LightGBM 3.X #21082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentzenchr
approved these changes
Sep 19, 2021
Comment on lines
232
to
235
| # TODO: Used decimal=2 when seed=0. acc_sklearn is 0.02 higher than | ||
| # acc_lightgbm with seed=0 | ||
| decimal = 1 if seed == 0 else 2 | ||
| np.testing.assert_almost_equal(acc_lightgbm, acc_sklearn, decimal=decimal) |
There was a problem hiding this comment.
In principle, I'm against seed dependent test tolerances. Can this situation be improved?
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
|
We might want to backport this for 1.0.1. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
…1082) Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…1082) Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #18316 (comment)
What does this implement/fix? Explain your changes.
Adds the scaling factor for
learning_ratewhen comparing with lightgbm and multiclass tasks.Any other comments?
This PR will enable us to compare interaction constraints in the CI in PR #21020 (as stated in #18316 (comment)).
CC @lorentzenchr @ogrisel