Skip to content

DOC Ensures that NeighborhoodComponentsAnalysis passes numpydoc validation #21083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmloyola
Copy link
Member

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures NeighborhoodComponentsAnalysis is compatible with numpydoc:

  • Remove NeighborhoodComponentsAnalysis from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.
  • Change docstrings to maintain consistency.

@glemaitre glemaitre merged commit 45bd756 into scikit-learn:main Sep 20, 2021
@glemaitre
Copy link
Member

Thanks @jmloyola looks good.

@jmloyola jmloyola deleted the fix_numpydoc_neighborhoodcomponentsanalysis branch September 21, 2021 01:12
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants