Skip to content

DOC - Ensure SGDRegressor passes numpydoc validation #21097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 23, 2021

Conversation

EricEllwanger
Copy link
Contributor

@EricEllwanger EricEllwanger commented Sep 21, 2021

Reference Issues/PRs

References #20308

What does this implement/fix? Explain your changes.

Changes to sklearn/linear_model/_stochastic_gradient.py:
Reordered Docstring section for SGDRegressor
Add descriptions for 'See Also' section for SGDRegressor
Added period to Docstring summary for SGDRegressor
Changed parameter learning_type to str in SGDRegressor
Added period to parmaetrs X and Y in BaseSGDRegressor.fit Docstring
Add description to Returns section in BaseSGDRegressor.fit Docstring
Added period to parmaetrs X and Y in BaseSGDRegressor.partial_fit Docstring
Add description to Returns section in BaseSGDRegressor.partial_fit Docstring
Added period to Docstring summary for BaseSGDRegressor.predict
Added description for parameter X for BaseSGDRegressor.predict Docstring

Removed SGDRegressor from DOCSTRING_IGNORE_LIST

Any other comments?

@glemaitre glemaitre merged commit 16ed158 into scikit-learn:main Sep 23, 2021
@glemaitre
Copy link
Member

Thanks @EricEllwanger

@EricEllwanger EricEllwanger deleted the doc-sgd branch September 24, 2021 00:23
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Oct 25, 2021
Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants