DRAFT: Implements fit params for RFECV #21113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This opens up a few issues, such as not passing those |
|
@adrinjalali oh that's a bummer. My intent here was to "Just" copy the feature I implemented on #20380 to RFECV. Do you have any suggestions on going forward? |
|
One reason this wasn't implemented in that other PR is exactly these challenges. We're really hoping to have the props PR merged for the next major release. That would be the ideal path forward. |
|
@adrinjalali thanks for clearing that up. I'll wait before that is implemented to tackle this. Do you think it is better to close this PR? |
|
yeah I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7308
What does this implement/fix? Explain your changes.
Fit params for RFECV
Any other comments?
This is a draft PR and it is broken. I uploaded just so I can keep my work more visible