Skip to content

DOC Fix minor issues in bike sharing example #21127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Sep 23, 2021

What does this implement/fix? Explain your changes.

This fixes the following minor issues:

  • removed [markdown] (this probably comes from writing the example in VS Code)
  • fix the code to divide the demand by the maximum demand (rather than by 1000) and be consistent with the text. Since df['count'].max() is 977 this does not change the performance numbers too much. I double-checked the few places in the text where we mention performance numbers
  • fix one performance number in the text 6% -> 5%, the exact number from running the code is:
Mean Absolute Error:     0.053 +/- 0.002

@glemaitre glemaitre changed the title Fix minor issues in bike demand example DOC Fix minor issues in bike sharing example Sep 23, 2021
@glemaitre glemaitre merged commit 30cc5d7 into scikit-learn:main Sep 23, 2021
@glemaitre
Copy link
Member

Thanks @lesteve

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@lesteve lesteve deleted the tweak-cyclical-features branch March 31, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants