Skip to content

DOC - Ensure StackingClassifier pass numpydoc validation #21135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 27, 2021

Conversation

EricEllwanger
Copy link
Contributor

Reference Issues/PRs

References #20308

What does this implement/fix? Explain your changes.

Changes to sklearn/ensemble/_stacking.py:
Added 'See Also' section to StackingClassifier Docstring
Made StackingClassifier.decision_function description fit on one line
Add description to 'Returns ' section for StackingClassifier.fit Docstring
Made StackingClassifier.proba Docstring description fit on one line

Removed StackingClassifier from DOCSTRING_IGNORE_LIST

Any other comments?

-->

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can make the docstring fit on a single line.

EricEllwanger and others added 2 commits September 24, 2021 10:51
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre glemaitre merged commit 9ed1c65 into scikit-learn:main Sep 27, 2021
@glemaitre
Copy link
Member

Thanks @EricEllwanger

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
…21135)

Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Oct 25, 2021
Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…21135)

Co-authored-by: frellwan <frellwan@hotmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants