MAINT move an orphaned vendored file around #21165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense. |
e71268f to
2e3c32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #21161.
What does this implement/fix? Explain your changes.
File
scipy/misc/pilutil.pyhas been removed from Scipy 1.3.0, see scipy/scipy#9325.Move
_pilutil.pyfromsklearn/externals, which is the location for vendored files, tosklearn/utils, which is a location for locally maintained files, including orphan vendored files like this one.Any other comments?
Perhaps this needs to be merged before #21161. Then I can rebase accordingly.