FIX Non-fit methods no long raises UserWarning for valid dataframes #21199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure comes from the fact that the underlying validation will not convert to the right sparse format in the neighbours. We should probably check for that. |
thomasjpfan
commented
Sep 30, 2021
jeremiedbb
approved these changes
Oct 1, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
…cikit-learn#21199) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
…21199) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#21199) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21188
What does this implement/fix? Explain your changes.
This PR removes the double validation warnings from the estimators and updates the common test to check for the warning.