BLD Build 3.10 wheel [cd build gh] #21232

thomasjpfan · 2021-10-03T22:48:19Z

Now that 3.10 wheels for numpy and scipy are in https://pypi.anaconda.org/scipy-wheels-nightly/simple, this PR enables us to build scikit-learn wheels with them.

Note that numpy and scipy is on manylinux2014.

thomasjpfan · 2021-10-04T03:06:59Z

pyproject.toml

@@ -3,7 +3,7 @@
 requires = [
    "setuptools",
    "wheel",
-    "Cython>=0.28.5",
+    "Cython>=0.28.5,<3.0",


Needed this to stop Cython 3.0 from installing with PIP_PRE=true

PIP_PRE=true is required because scipy 3.10 is only avaliable as a dev release in https://pypi.anaconda.org/scipy-wheels-nightly/simple

thomasjpfan · 2021-10-04T03:21:19Z

.github/workflows/wheels.yml

+      # Comment out when numpy/scipy dependencies are on pypi
+      - name: Set pypi index for python dev
+        if: matrix.python == 310
+        run: |
+          echo "EXTRA_CIBW_ENVIRONMENT=PIP_EXTRA_INDEX_URL=https://pypi.anaconda.org/scipy-wheels-nightly/simple PIP_PRE=true" >> $GITHUB_ENV
+
+          # Do not use the dev version of pandas
+          echo "PANDAS_VERSION_SPECIFIER=<1.4" >> $GITHUB_ENV


When a new version of Python come up, I expect the builds for the Python RC to be in https://pypi.anaconda.org/scipy-wheels-nightly/simple first, so setting PIP_PRE=true is required to automatically get the dev builds.

Currently there is a mix of Python 3.10 wheels on scipy-wheels-nightly and on pypi. numpy and pandas is on pypi and scipy is on scipy-wheels-nightly.

thomasjpfan · 2021-10-04T13:18:39Z

Marked for 1.0.1 so we can have Python 3.10 builds for 1.0.X

ogrisel · 2021-10-05T17:01:43Z

build_tools/github/check_build_trigger.sh

@@ -7,6 +7,7 @@ COMMIT_MSG=$(git log --no-merges -1 --oneline)

 # The commit marker "[cd build]" will trigger the build when required
 if [[ "$GITHUB_EVENT_NAME" == schedule ||
-      "$COMMIT_MSG" =~ \[cd\ build\] ]]; then
+      "$COMMIT_MSG" =~ \[cd\ build\] ||
+      "$COMMIT_MSG" =~ \[cd\ build\ gh\] ]]; then


do we have this documented?

now we do (as part of #21849).

ogrisel · 2021-10-05T17:03:11Z

It nice to see that it works but shouldn't we wait for numpy and scipy to be release for Python 3.10 before merging this with a simpler config that does not rely on the dev wheels?

thomasjpfan · 2021-10-05T17:35:07Z

It nice to see that it works but shouldn't we wait for numpy and scipy to be release for Python 3.10 before merging this with a simpler config that does not rely on the dev wheels?

I agree. I'll place this PR into draft mode and take it out of draft when numpy/scipy wheels are on pypi.

thomasjpfan · 2021-10-22T13:14:54Z

Still waiting on MacPython/scipy-wheels#132

thomasjpfan · 2021-11-08T22:32:14Z

SciPy on Windows & Python 3.10 is now fixed on PyPi. This PR should be good to go.

ulupo · 2021-11-17T15:07:47Z

Hi! Thanks to the scikit-learn team for being so quick at work with the Python 3.10 wheels. Just wondering, for the purposes of a package I maintain which has scikit-learn as a dependency, whether there is a target timeline for merging this PR and for releasing the wheels on PyPI?

adrinjalali

Thanks @thomasjpfan

adrinjalali · 2021-11-18T18:27:36Z

build_tools/github/check_build_trigger.sh

@@ -7,6 +7,7 @@ COMMIT_MSG=$(git log --no-merges -1 --oneline)

 # The commit marker "[cd build]" will trigger the build when required
 if [[ "$GITHUB_EVENT_NAME" == schedule ||
-      "$COMMIT_MSG" =~ \[cd\ build\] ]]; then
+      "$COMMIT_MSG" =~ \[cd\ build\] ||
+      "$COMMIT_MSG" =~ \[cd\ build\ gh\] ]]; then


do we have this documented?

build_tools/github/check_wheels.py

ogrisel

LGTM once the remaining review comments are dealt with. Thanks very much @thomasjpfan!

.travis.yml

ogrisel · 2021-11-19T11:13:31Z

Hi! Thanks to the scikit-learn team for being so quick at work with the Python 3.10 wheels. Just wondering, for the purposes of a package I maintain which has scikit-learn as a dependency, whether there is a target timeline for merging this PR and for releasing the wheels on PyPI?

Once merged, will need to backport this to the 1.0.X branch. From there we could either build some Python 3.10 wheels for 1.0.1 and upload them manually to pypi or we could wait for 1.0.2 which should happen soon-ish.

ulupo · 2021-11-19T12:28:57Z

Thanks @ogrisel and @thomasjpfan !

ogrisel

LGTM assuming CI stays green after the merge conflicts resolution. If #21827 is merged first we will need to add the Python 3.10 entry to macos/arm64 here before merging.

ogrisel · 2021-12-02T10:04:08Z

The unrelated Azure Pipelines failures on Windows has already been reported here: #21798.

glemaitre · 2021-12-02T13:27:55Z

Nice.

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

thomasjpfan added 14 commits October 3, 2021 18:45

BLD Build 3.10 wheel for linux [cd build gh]

c066962

BLD Test matrix [cd build gh]

578d849

BLD Test matrix fix [cd build gh]

f4f1d41

BLD Test matrix fix [cd build gh]

a9d3c94

BLD Only test 310 [cd build gh]

0d57609

BLD Do not use prerelease cython [cd build gh]

1b519e2

REV smaller diff [cd build gh]

418fe03

BLD pin cython [cd build gh]

0e00fc4

BLD Do not use dev version of pandas [cd build gh]

5de67ed

BLD Test build matrix [cd build gh]

6471b97

BLD Actually build wheels [cd build gh]

ebdf681

BLD Slightly better variables [cd build gh]

6e75f76

BLD Slightly better matrix formulation [cd build gh]

eea348b

BLD Slightly better matrix formulation [cd build gh]

6fb72cf

thomasjpfan marked this pull request as ready for review October 4, 2021 03:06

thomasjpfan commented Oct 4, 2021

View reviewed changes

thomasjpfan added this to the 1.0.1 milestone Oct 4, 2021

ogrisel reviewed Oct 5, 2021

View reviewed changes

thomasjpfan removed this from the 1.0.1 milestone Oct 5, 2021

thomasjpfan marked this pull request as draft October 5, 2021 17:32

thomasjpfan mentioned this pull request Oct 8, 2021

CI Adds CPython 3.10 testing [python-dev] #20942

Closed

thomasjpfan added 3 commits October 21, 2021 10:51

Merge remote-tracking branch 'upstream/main' into wheel_3_10

8657237

REV Less diffs

0c4e817

Merge remote-tracking branch 'upstream/main' into wheel_3_10

4d90ea3

glemaitre mentioned this pull request Oct 22, 2021

Add wheels for Python 3.10 #21401

Closed

mtreinish mentioned this pull request Nov 15, 2021

Add support for Python 3.10 Qiskit/qiskit#7102

Merged

8 tasks

Merge remote-tracking branch 'upstream/main' into wheel_3_10

2ea78a8

thomasjpfan changed the title ~~BLD Build 3.10 wheel for linux [cd build gh]~~ BLD Build 3.10 wheel [cd build gh] Nov 18, 2021

BLD Check build [cd build]

b691d76

adrinjalali reviewed Nov 18, 2021

View reviewed changes

ogrisel approved these changes Nov 19, 2021

View reviewed changes

.travis.yml Show resolved Hide resolved

.travis.yml Show resolved Hide resolved

ogrisel added this to the 1.0.2 milestone Nov 19, 2021

ogrisel added To backport PR merged in master that need a backport to a release branch defined based on the milestone. No Changelog Needed labels Nov 19, 2021

thomasjpfan added 5 commits November 19, 2021 09:35

CLN Address comments

15de3b8

CLN Increase CPU_COUNT on arm since it vm has more memory [cd build]

e0eeb55

Merge remote-tracking branch 'upstream/main' into wheel_3_10 [cd build]

ca21f91

DOC Update whats new

db9db2b

Merge remote-tracking branch 'upstream/main' into wheel_3_10

d08cc16

thomasjpfan mentioned this pull request Dec 1, 2021

CI Explicitly list out wheel builds in config [cd build gh] #21849

Merged

ogrisel added 2 commits December 2, 2021 10:55

Merge branch 'main' into wheel_3_10

ff868b6

Update check_wheels.py [cd build]

d0b4235

ogrisel mentioned this pull request Dec 2, 2021

CI Build macOS arm wheels [cd build gh] #21827

Merged

ogrisel approved these changes Dec 2, 2021

View reviewed changes

ogrisel merged commit 8876439 into scikit-learn:main Dec 2, 2021

thomasjpfan mentioned this pull request Dec 5, 2021

Please add support for python3.10 #21882

Closed

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021

BLD Build 3.10 wheel [cd build gh] (scikit-learn#21232)

aeddb6c

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

glemaitre pushed a commit that referenced this pull request Dec 25, 2021

BLD Build 3.10 wheel [cd build gh] (#21232)

f90c33f

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

DanArlowski mentioned this pull request Jan 20, 2022

[BUG] add python 3.10 to test matrix deepchecks/deepchecks#711

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BLD Build 3.10 wheel [cd build gh] #21232

BLD Build 3.10 wheel [cd build gh] #21232

thomasjpfan commented Oct 3, 2021 •

edited by glemaitre

Loading

thomasjpfan Oct 4, 2021

thomasjpfan Oct 4, 2021

thomasjpfan commented Oct 4, 2021

ogrisel Oct 5, 2021

adrinjalali Nov 18, 2021

ogrisel Dec 2, 2021

ogrisel commented Oct 5, 2021

thomasjpfan commented Oct 5, 2021

thomasjpfan commented Oct 22, 2021

thomasjpfan commented Nov 8, 2021

ulupo commented Nov 17, 2021 •

edited

Loading

adrinjalali left a comment

adrinjalali Nov 18, 2021

ogrisel left a comment

ogrisel commented Nov 19, 2021

ulupo commented Nov 19, 2021

ogrisel left a comment

ogrisel commented Dec 2, 2021

glemaitre commented Dec 2, 2021

BLD Build 3.10 wheel [cd build gh] #21232

BLD Build 3.10 wheel [cd build gh] #21232

Conversation

thomasjpfan commented Oct 3, 2021 • edited by glemaitre Loading

thomasjpfan Oct 4, 2021

Choose a reason for hiding this comment

thomasjpfan Oct 4, 2021

Choose a reason for hiding this comment

thomasjpfan commented Oct 4, 2021

ogrisel Oct 5, 2021

Choose a reason for hiding this comment

adrinjalali Nov 18, 2021

Choose a reason for hiding this comment

ogrisel Dec 2, 2021

Choose a reason for hiding this comment

ogrisel commented Oct 5, 2021

thomasjpfan commented Oct 5, 2021

thomasjpfan commented Oct 22, 2021

thomasjpfan commented Nov 8, 2021

ulupo commented Nov 17, 2021 • edited Loading

adrinjalali left a comment

Choose a reason for hiding this comment

adrinjalali Nov 18, 2021

Choose a reason for hiding this comment

ogrisel left a comment

Choose a reason for hiding this comment

ogrisel commented Nov 19, 2021

ulupo commented Nov 19, 2021

ogrisel left a comment

Choose a reason for hiding this comment

ogrisel commented Dec 2, 2021

glemaitre commented Dec 2, 2021

thomasjpfan commented Oct 3, 2021 •

edited by glemaitre

Loading

ulupo commented Nov 17, 2021 •

edited

Loading