Skip to content

DOC Ensures that PatchExtractor passes numpydoc validation #21233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

jmloyola
Copy link
Member

@jmloyola jmloyola commented Oct 4, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures PatchExtractor is compatible with numpydoc:

  • Remove PatchExtractor from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.
  • Change docstrings to maintain consistency.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jmloyola !

LGTM

@thomasjpfan thomasjpfan merged commit 23afd5d into scikit-learn:main Oct 4, 2021
@jmloyola jmloyola deleted the fix_numpydoc_patchextractor branch October 4, 2021 17:40
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants