-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Ensures that SplineTransformer passes numpydoc validation #21248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrinjalali
merged 2 commits into
scikit-learn:main
from
Pinky-Chaudhary:fix_numpydoc_splinetransformer
Oct 7, 2021
Merged
DOC Ensures that SplineTransformer passes numpydoc validation #21248
adrinjalali
merged 2 commits into
scikit-learn:main
from
Pinky-Chaudhary:fix_numpydoc_splinetransformer
Oct 7, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, @Pinky-Chaudhary.
Thanks @jjerphan for review, would like to ask you to label this PR as |
Sorry for Initiating a re-review it was by mistake please ignore that. |
adrinjalali
approved these changes
Oct 7, 2021
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Oct 8, 2021
…-learn#21248) * Remove SplineTransformer from DOCSTRING_IGNORE_LIST * Fix numpydocs from SplineTransformer
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
…-learn#21248) * Remove SplineTransformer from DOCSTRING_IGNORE_LIST * Fix numpydocs from SplineTransformer
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
* Remove SplineTransformer from DOCSTRING_IGNORE_LIST * Fix numpydocs from SplineTransformer
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…-learn#21248) * Remove SplineTransformer from DOCSTRING_IGNORE_LIST * Fix numpydocs from SplineTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures SplineTransformer is compatible with numpydoc:
SplineTransformer
fromDOCSTRING_IGNORE_LIST
.