DOC Linear regression doc update #21258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Oct 6, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
reviewed
Oct 7, 2021
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
|
Thank you for the rewievs and the comments. 👍 |
jjerphan
approved these changes
Oct 8, 2021
adrinjalali
approved these changes
Oct 12, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
* update docstring * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Update sklearn/linear_model/_base.py Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
* update docstring * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Update sklearn/linear_model/_base.py Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
* update docstring * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Update sklearn/linear_model/_base.py Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21254.
Related to #14228.
What does this implement/fix? Explain your changes.
By fitting a LinearRegression the n_jobs parameter can set the number of threads only in case of positive=True or in case of sp.issparse(X). In other cases the linalg.lstsq is called which can handle (M, K) shaped y and there is no parameter like n_jobs in this call.
Docstring is updated according to this.