Skip to content

DOC Ensures that KNNImputer passes numpydoc validation #21272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

baam25simo
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

  • KNNImputer removed from DOCSTRING_IGNORE_LIST in test_docstrings.py
  • In KNNImputer.__init__: "See Also" section added.
  • In KNNImputer.fit: y and return description parameters added.

@baam25simo baam25simo changed the title [DOC] Ensures that KNNImputer passes numpydoc validation DOC Ensures that KNNImputer passes numpydoc validation Oct 7, 2021
Fix proposal
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @baam25simo.

@glemaitre glemaitre self-requested a review October 21, 2021 09:31
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit a17430c into scikit-learn:main Oct 21, 2021
@glemaitre
Copy link
Member

Thanks @baam25simo

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
…21272)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…21272)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants