[DOC] Remove "mse" from RandomForestRegression docstring
#21306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _"mae"_ criterion was removed from the docstring in 36915ae. For consistency I think that _"mse"_ should be removed as well since both were deprecated in 1.0.
RandomForestRegression docstringRandomForestRegression docstring
thomasjpfan
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Thank you for the PR @luxedo !
I think it would be okay to remove the option from the docstring. (We are already removed "mae")
RandomForestRegression docstringRandomForestRegression docstring
adrinjalali
approved these changes
Oct 13, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
…arn#21306) The _"mae"_ criterion was removed from the docstring in 36915ae. For consistency I think that _"mse"_ should be removed as well since both were deprecated in 1.0.
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
The _"mae"_ criterion was removed from the docstring in 36915ae. For consistency I think that _"mse"_ should be removed as well since both were deprecated in 1.0.
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…arn#21306) The _"mae"_ criterion was removed from the docstring in 36915ae. For consistency I think that _"mse"_ should be removed as well since both were deprecated in 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The "mae" criterion was removed from the docstring in 36915ae. For consistency I think that "mse" should be removed as well since both were deprecated in 1.0.
Any other comments?
Both criterions are still in
ExtraTreesRegressorand I think they could be removed as well.