-
-
Notifications
You must be signed in to change notification settings - Fork 26k
MNT try non-scientific formatting in numpy output #21329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @glemaitre |
Nop. It does not seem to work. But I don't understand why only one build is failing while we have several builds with NumPy 1.21.2? |
I did not look at it yet, but I found this entry in the release note: https://numpy.org/doc/stable/release/1.21.0-notes.html#new-min-digits-argument-for-printing-float-values |
And I can't reproduce it on a conda environment with the same versions. Hmmm @rgommers anywhere in particular you could point us at? |
That looks unfamiliar to me. It may have been an unintended side effect of numpy/numpy#18629. @ahaldane, @seberg any thoughts on this one? |
I don't really understand it, or how it would have to do anything with this. Would it be possible to get the print options to see if it is possible/how to reproduce it? Because I cannot locally. |
@seberg here's the print options right where the error happens:
|
It's very confusing, because locally I have the same numpy version, the same print options, but this is what I get: >>> numpy.float64(9.987631416202845e-01)
0.9987631416202845
>>> numpy.array([9.987631416202845e-01])
array([0.99876314]) which is what I'd expect, but it's not what we get in the CI. |
Are you sure to pull from the default channel and use MKL?
…On Thu, 14 Oct 2021 at 21:12, Adrin Jalali ***@***.***> wrote:
It's very confusing, because locally I have the same numpy version, the
same print options, but this is what I get:
>>> numpy.float64(9.987631416202845e-01)0.9987631416202845>>> numpy.array([9.987631416202845e-01])array([0.99876314])
which is what I'd expect, but it's not what we get in the CI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P42BZN76I2NJUJFMK3UG4TS7ANCNFSM5F7VJ7WQ>
.
--
Guillaume Lemaitre
Scikit-learn @ Inria Foundation
https://glemaitre.github.io/
|
I did the same install and indeed I cannot reproduce it.
|
Confusing, is it possible that the runner has custom, non-default, printing for float objects? Maybe try printing repr/string for the normal Python float? |
So it seems like some patch on python or other libs on the conda main channel. Using conda-forge fixes the issue (I think): #21337 |
I think we can close this debug PR because this specific problem has gone away. |
Maybe fixes #21324
Trying to see if this fixes our issues with numpy formats