ENH Smoke test for invalid parameters in __init__ and get_params #21355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Besides the comment below, the test it-self looks like a good idea.
I am not sure that Pipeline and FeatureUnion or other complex meta-estimators will all ever pass this test though, but for "regular" estimators, I think it's a good idea not to validate in __init__ or set_params in general.
I would not make it a check_estimator requirement though.
ogrisel
reviewed
Oct 20, 2021
ogrisel
reviewed
Oct 21, 2021
|
I assume that we need to open a subsequent issue to reduce the list of the estimator validating parameters in the wrong place. |
glemaitre
approved these changes
Oct 22, 2021
|
Somehow I thought I added that test before but I guess I just complained loudly three years ago in #12652. lol... |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
avm19
pushed a commit
to avm19/scikit-learn
that referenced
this pull request
Apr 11, 2022
…at setter, keep at getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #16945
What does this implement/fix? Explain your changes.
This PR adds a new test that checks that no validation is done during
__init__andset_params. I fixed the on in_BaseCompositionbecause it is inherited by many estimators.Any other comments?
Maybe this can be a good intermediate sprint issue?