Skip to content

FIX error message for mixed metric input (for #2137) #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FIX error message for mixed metric input (for #2137) #2139

wants to merge 1 commit into from

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Jul 9, 2013

No description provided.

@arjoly
Copy link
Member

arjoly commented Jul 9, 2013

Thanks to handle this!

It would be great to add a regression test with assert_raise_message.

@jnothman
Copy link
Member Author

jnothman commented Jul 9, 2013

yes, i considered that, but don't really have the time to work out what the exact functional requirements are in terms of an error message...

@arjoly
Copy link
Member

arjoly commented Jul 9, 2013

By simplifying the function and the error message, I come to this solution https://gist.github.com/arjoly/5955296.

@jnothman
Copy link
Member Author

jnothman commented Jul 9, 2013

At a glance that looks fine. I'm happy to close this PR and you propose that rewrite,

@arjoly
Copy link
Member

arjoly commented Jul 10, 2013

Ok, I will do this.

@arjoly
Copy link
Member

arjoly commented Jul 10, 2013

Replace by #2147

@arjoly arjoly closed this Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnothman @arjoly