Skip to content

Conversation

gpablo6
Copy link
Contributor

@gpablo6 gpablo6 commented Oct 23, 2021

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

This PR ensures that sklearn.cluster._kmeans.k_means passes numpydoc validation

  • Remove the function from the list FUNCTION_DOCSTRING_IGNORE_LIST
  • Verify that all tests are passed

Any other comments?

Co-authored-by: Juan Martin Loyola jmloyola@outlook.com

#DataUmbrella sprint

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
@amueller
Copy link
Member

You need to fix the merge conflict :)

@glemaitre
Copy link
Member

Since the CIs are happy, I just solve the conflict and I am merging. Thanks @gpablo6 @jmloyola

@glemaitre glemaitre merged commit bf6db7b into scikit-learn:main Oct 23, 2021
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Oct 28, 2021
…dation (scikit-learn#21423)

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…dation (scikit-learn#21423)

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
…dation (scikit-learn#21423)

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Dec 25, 2021
…dation (#21423)

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants