Skip to content

Conversation

MaggieChege
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Fixing docs to allow allow as_float_array docstring to pass numpydoc validation in sklearn.utils.validation.as_float_array

Any other comments?

#DataUmbrella Sprint
(@reshamas)

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the following comment is addressed:

@ogrisel ogrisel merged commit 53016b8 into scikit-learn:main Oct 29, 2021
@ogrisel
Copy link
Member

ogrisel commented Oct 29, 2021

Thanks!

@reshamas reshamas added the Sprint label Nov 5, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
Co-authored-by: ciku <maggie@hellotractor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants