MNT Postpone conversion of RidgeCV's alphas out of __init__
#21506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Oct 29, 2021
ogrisel
reviewed
Oct 29, 2021
|
Following @ogrisel comment, I think that we are missing a couple of changes that are removing However, the common test implemented for #21406 is not good enough to detect these cases. I assume that we would like to check that the IDs of the provided parameters in |
_scale_alpha_inplace to ensure broadcastingRidgeCV's alphas out of __init__
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Encompasses the scope of #21406. See also #19426.
What does this implement/fix? Explain your changes.
alphasused to be converted to anp.ndarrayinside__init__.This is now postponed to
fitto follow the scikit-learn API.As
alphascan now be a list, we modify the_scale_alpha_inplacetest accordingly.A new test
ridgecv_alphas_conversionis created to ensurealphasare converted duringfit.This PR also clarifies the docstring of
_scale_alpha_inplace.Any other comments?