Skip to content

MAINT Removes short summary for most builds #21554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2021
Merged

MAINT Removes short summary for most builds #21554

merged 4 commits into from
Nov 6, 2021

Conversation

thomasjpfan
Copy link
Member

When looking at CI builds, I frequently scroll pass the summary. This PR removes the summary except for one of the builds on the CI.

CC @jjerphan @glemaitre @ogrisel

jjerphan
jjerphan approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting you, @thomasjpfan: LGTM.

glemaitre
glemaitre reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine skipping the short summary for most of the build and keeping it only for one of them (sometimes it could be useful to check so skipped or xfail)

jeremiedbb
jeremiedbb reviewed Nov 4, 2021
View reviewed changes
@jeremiedbb
Copy link
Member

I think it's worth adding that to posix-docker.yml and to windows.yml as well

@ogrisel
Copy link
Member

ogrisel commented Nov 5, 2021

Thank you so much for working this out @thomasjpfan. Thinking about it, wouldn't it make sense to directly update the [tool:pytest] section of setup.cfg instead of changing the CI configuration?

@thomasjpfan
Copy link
Member Author

Thinking about it, wouldn't it make sense to directly update the [tool:pytest] section of setup.cfg instead of changing the CI configuration?

That makes sense. I updated the PR to adjust setup.cfg. Note, to get the summary locally, we need to run pytest -ra.

ogrisel
ogrisel approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if it's really necessary to keep it enabled for pylatest_conda_forge_mkl but this is already a net improvement and I agree we should keep it for at least one of the builds.

Let's merge and we can adjust in a subsequent PR based on experience.

@ogrisel ogrisel merged commit 48e83df into scikit-learn:main Nov 6, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
@thomasjpfan @glemaitre
MAINT Removes short summary for most builds (scikit-learn#21554)
727858e
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@thomasjpfan @samronsin
MAINT Removes short summary for most builds (scikit-learn#21554)
b2a5273
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@thomasjpfan @glemaitre
MAINT Removes short summary for most builds (scikit-learn#21554)
a8efa8a
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
@thomasjpfan @glemaitre
MAINT Removes short summary for most builds (#21554)
687ddbd
@lesteve lesteve mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jeremiedbb jeremiedbb jeremiedbb left review comments

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasjpfan @jeremiedbb @ogrisel @glemaitre @jjerphan