-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG] Speed up plot_discretization_classification.py #21661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Speed up plot_discretization_classification.py #21661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nice improvement, I wouldn't have changed c_
, but I also don't mind the change.
And nice catch on the StandardScaler
issue.
you need to apply Also, please merge with the latest |
I forgot to merge the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks !
Reference Issues/PRs
#21598
What does this implement/fix? Explain your changes.
I reduce the parameter search space.
Another issue: the original code standardizes the entire dataset, which may cause data leakage. I moved the
StandardScaler
into the pipelines.before: 28s


after: 6s
Any other comments?