Skip to content

MAINT reorg/fix Kernel PCA entry in whats_new/v1.1.rst #21695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 17, 2021

Missed during the review of #21567.

Should resolve the merge conflict of #21079.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for #21567. LGTM.

Current CI failures are unrelated to those changes.

@jjerphan jjerphan merged commit 7ec4400 into scikit-learn:main Nov 17, 2021
@ogrisel ogrisel deleted the fix-whats_new-v1.1-kernelpca branch November 17, 2021 13:29
@ogrisel
Copy link
Member Author

ogrisel commented Nov 17, 2021

My bad for #21567. LGTM.

No problem I have done countless such oversights myself. I did not want to blame anybody.

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 22, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants