Skip to content

DOC Ensures that mean_absolute_error passes numpydoc validation #21714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2022
Merged

DOC Ensures that mean_absolute_error passes numpydoc validation #21714

merged 3 commits into from
Jan 28, 2022

Conversation

ebsano
Copy link
Contributor

@ebsano ebsano commented Nov 19, 2021

Reference Issues/PRs

Reference Issues/PRs
Addresses #21350
#DataUmbrella

This PR ensures mean_absolute_error is compatible with numpydoc:

  • Remove sklearn.metrics._regression.mean_absolute_error from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.

@thomasjpfan thomasjpfan mentioned this pull request Nov 22, 2021
Closed
@reshamas
Copy link
Member

Hi @ebsano
How is this PR going?
I checked the error and it looks like if you run black on the files you changed, it should take care of the errors.

Alternately, you can use pre-commit. This will check for formatting errors at the time you commit your changes.
To install:

pip install pre-commit
pre-commit install

@glemaitre glemaitre self-assigned this Jan 28, 2022
glemaitre
glemaitre approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let see if the CI will pass now that I merge main into the branch

@glemaitre glemaitre merged commit c206f4a into scikit-learn:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees

@glemaitre glemaitre

Labels
Documentation module:metrics No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebsano @reshamas @glemaitre