Skip to content

Old test for pull request #21753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Old test for pull request #21753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418f66d
Handle type problems for get_feature_names
jfreneau Nov 22, 2021
34ca7cb
Merge branch 'scikit-learn:main' into main
jfreneau Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sklearn/preprocessing/_encoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,9 @@ def get_feature_names(self, input_features=None):

feature_names = []
for i in range(len(cats)):
names = [input_features[i] + "_" + str(t) for t in cats[i]]
if type(input_features[i]) is not str:
raise Warning("Your features names are not strings. This may cause errors later on.")
names = [str(input_features[i]) + "_" + str(t) for t in cats[i]]
if self.drop_idx_ is not None and self.drop_idx_[i] is not None:
names.pop(self.drop_idx_[i])
feature_names.extend(names)
Expand Down Expand Up @@ -724,7 +726,9 @@ def get_feature_names_out(self, input_features=None):

feature_names = []
for i in range(len(cats)):
names = [input_features[i] + "_" + str(t) for t in cats[i]]
if type(input_features[i]) is not str:
raise Warning("Your features names are not strings. This may cause errors later on.")
names = [str(input_features[i]) + "_" + str(t) for t in cats[i]]
if self.drop_idx_ is not None and self.drop_idx_[i] is not None:
names.pop(self.drop_idx_[i])
feature_names.extend(names)
Expand Down