EXA Update OpenML dataset in plot_gradient_boosting_categorical #21789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Nov 26, 2021
| @@ -69,7 +69,6 @@ | |||
| print(f"Number of categorical features: {n_categorical_features}") | |||
| print(f"Number of numerical features: {n_numerical_features}") | |||
|
|
|||
| # %% | |||
There was a problem hiding this comment.
You need to reintroduce all these markers. They are used to define the sections.
Now, the rendering is broken.
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21782
@glemaitre @pedugnat
Adapting dataset by applying changes proposed from @glemaitre in #21782 since the current OpenML dataset seems to be unuseable. This PR follows #21788 which was closed due to sync problems with the upstream main