Skip to content

ENH Loss module LogisticRegression #21808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Feb 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
bf2b0cf
ENH replace loss in linear logistic regression
lorentzenchr Jan 1, 2021
f74bdde
MNT remove logistic regression's own loss functions
lorentzenchr Jan 1, 2021
5596ab2
CLN remove comment
lorentzenchr Nov 28, 2021
b6a96ce
DOC add whatsnew
lorentzenchr Nov 28, 2021
9803d8a
DOC more precise whatsnew
lorentzenchr Nov 28, 2021
c9e211f
CLN restore improvements of #19571
lorentzenchr Nov 28, 2021
68b1d11
Merge branch 'main' into loss_module_logistic
lorentzenchr Nov 30, 2021
d36c17b
ENH improve fit time by separating mat-vec in multiclass
lorentzenchr Dec 1, 2021
faa16ec
DOC update whatsnew
lorentzenchr Dec 1, 2021
e4d4432
not only a bit ;-)
lorentzenchr Dec 1, 2021
3deafab
DOC note memory benefit for multiclass case
lorentzenchr Dec 1, 2021
9d10861
trigger CI
lorentzenchr Dec 4, 2021
3dba3f8
trigger CI
lorentzenchr Dec 6, 2021
a8b2a27
Merge branch 'main' into loss_module_logistic
lorentzenchr Dec 8, 2021
e588e33
CLN rename variable to hess_prod
lorentzenchr Dec 10, 2021
f1c189d
Merge branch 'main' into loss_module_logistic
lorentzenchr Dec 15, 2021
3104648
DOC address reviewer comments
lorentzenchr Dec 15, 2021
639c16c
CLN remove C/F for 1d arrays
lorentzenchr Dec 15, 2021
b7230e1
CLN rename to gradient_per_sample
lorentzenchr Dec 15, 2021
17c674d
CLN rename alpha to l2_reg_strength
lorentzenchr Dec 15, 2021
39ffe9d
ENH respect F-contiguity
lorentzenchr Dec 16, 2021
357fe2b
TST fix sag tests
lorentzenchr Dec 16, 2021
09fe29d
CLN rename to LinearModelLoss
lorentzenchr Dec 16, 2021
a4b1b6b
CLN improve comments according to review
lorentzenchr Dec 16, 2021
8dfe165
CLN liblinear comment
lorentzenchr Dec 16, 2021
fa249c3
TST add / move test to test_linear_loss.py
lorentzenchr Dec 17, 2021
dea9bf0
CLN comment placement
lorentzenchr Dec 17, 2021
3731fc7
trigger CI
lorentzenchr Dec 17, 2021
1e56ae7
CLN add comment about contiguity of raw_prediction
lorentzenchr Dec 18, 2021
ef0b98f
DEBUG debian-32
lorentzenchr Dec 18, 2021
9d6e698
DEBUG test only linear_model module
lorentzenchr Dec 19, 2021
41d1497
Revert "DEBUG test only linear_model module"
lorentzenchr Dec 19, 2021
c203167
DEBUG test -k LogisticRegression
lorentzenchr Dec 19, 2021
edc87ae
Revert "DEBUG test -k LogisticRegression"
lorentzenchr Dec 19, 2021
3b890fd
Revert "DEBUG debian-32"
lorentzenchr Dec 19, 2021
c7f6f72
DEBUG set n_jobs=1
lorentzenchr Dec 20, 2021
028fc61
Revert "DEBUG set n_jobs=1"
lorentzenchr Dec 20, 2021
8becaa5
Merge branch 'main' into loss_module_logistic
lorentzenchr Dec 20, 2021
8ce99fe
Merge branch 'main' into loss_module_logistic
lorentzenchr Dec 20, 2021
aadf1d2
CLN always use n_threads=1
lorentzenchr Dec 20, 2021
a45d94c
CLN address review
lorentzenchr Dec 21, 2021
cb2a8a2
ENH avoid array copy
lorentzenchr Dec 21, 2021
08be484
CLN simplify L2 norm
lorentzenchr Dec 21, 2021
6325270
CLN rename w to weights
lorentzenchr Dec 21, 2021
c2b599b
CLN rename to hessian_sum and hx_sum
lorentzenchr Dec 21, 2021
b241971
Merge branch 'main' into loss_module_logistic
lorentzenchr Dec 21, 2021
013eeec
Merge branch 'main' into loss_module_logistic
ogrisel Dec 31, 2021
b24afbb
CLN address review
lorentzenchr Jan 2, 2022
5a9de8c
Merge branch 'loss_module_logistic' of https://github.com/lorentzench…
lorentzenchr Jan 2, 2022
4f704d4
Merge branch 'main' into loss_module_logistic
ogrisel Jan 12, 2022
8e5e319
Merge branch 'main' into loss_module_logistic
lorentzenchr Jan 12, 2022
4631688
Merge branch 'loss_module_logistic' of https://github.com/lorentzench…
lorentzenchr Jan 12, 2022
4e8681b
CLN rename to init arg and attribute to base_loss
lorentzenchr Feb 1, 2022
ee066bb
CLN apply review suggestion
lorentzenchr Feb 9, 2022
4ffac56
Merge branch 'main' into loss_module_logistic
lorentzenchr Feb 9, 2022
c28a630
Merge branch 'loss_module_logistic' of https://github.com/lorentzench…
lorentzenchr Feb 9, 2022
190c264
CLN base_loss instead of _loss attribute
lorentzenchr Feb 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/whats_new/v1.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,15 @@ Changelog
beginning which speeds up fitting.
:pr:`22206` by :user:`Christian Lorentzen <lorentzenchr>`.

- |Enhancement| :class:`~linear_model.LogisticRegression` is faster for
``solvers="lbfgs"`` and ``solver="newton-cg"``, for binary and in particular for
multiclass problems thanks to the new private loss function module. In the multiclass
case, the memory consumption has also been reduced for these solvers as the target is
now label encoded (mapped to integers) instead of label binarized (one-hot encoded).
The more classes, the larger the benefit.
:pr:`21808`, :pr:`20567` and :pr:`21814` by
:user:`Christian Lorentzen <lorentzenchr>`.

- |Enhancement| Rename parameter `base_estimator` to `estimator` in
:class:`linear_model.RANSACRegressor` to improve readability and consistency.
`base_estimator` is deprecated and will be removed in 1.3.
Expand Down
Loading