Skip to content

API add intercept_ attribute to PLS estimators #22015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 2, 2022

Conversation

glemaitre
Copy link
Member

closes #19890

Add the intercept_ fitted attributes to the different PLS estimators since it is used when predicting as any other linear model.

@glemaitre
Copy link
Member Author

ping @NicolasHug I think that it makes sense somehow.

@glemaitre glemaitre added this to the 1.1 milestone Apr 27, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks reasonable to have.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 2, 2022
@jeremiedbb jeremiedbb merged commit 452ede0 into scikit-learn:main May 2, 2022
@glemaitre
Copy link
Member Author

glemaitre commented May 2, 2022

🦊 Thanks @jeremiedbb

jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request May 10, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:cross_decomposition To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLSRegression could expose an intercept_ attribute
3 participants