Skip to content

DOC Ensures spectral_clustering clustering numpydoc validation #22025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2022
Merged

DOC Ensures spectral_clustering clustering numpydoc validation #22025

merged 5 commits into from
Jan 28, 2022

Conversation

moonkyung-kang
Copy link
Contributor

Reference Issues/PRs

#21350

What does this implement/fix? Explain your changes.

End the sentence with a period.
Sections are in the wrong order. Correct order is: Parameters, Returns, Notes, References

Any other comments?

@glemaitre
Copy link
Member

I will try to merge main into your branch but I was under the impression that we already merge such fixes for these functions.

@glemaitre glemaitre self-assigned this Jan 28, 2022
glemaitre
glemaitre reviewed Jan 28, 2022
View reviewed changes
glemaitre
glemaitre approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is updating the spectral_clustering function so we are fine. Let's wait for the CIs to pass.

@glemaitre glemaitre merged commit 4a4d135 into scikit-learn:main Jan 28, 2022
@thomasjpfan thomasjpfan changed the title DOC Ensures sklearn.cluster. spectral.spectral clustering numpydoc validation DOC Ensures spectral_clustering clustering numpydoc validation Mar 12, 2022
@thomasjpfan thomasjpfan mentioned this pull request Mar 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees

@glemaitre glemaitre

Labels
Documentation module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonkyung-kang @glemaitre