-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
CI Fixes wheel building #22051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Fixes wheel building #22051
Conversation
63b6979
to
aa8cd96
Compare
There are some failures with scipy on 32bit linux: https://github.com/scikit-learn/scikit-learn/runs/4600069041?check_suite_focus=true |
Would we trigger the following error by not creating the |
The issue with |
The issue in #19233 came from their configuration was not using
This will not fix everything because older version of NumPy will not get the fix. |
I really like how SciPy's pyproject.toml places upper bounds in release branches. Their development branch has no upper bounds. I think we need to pin |
Yep let's drop it then. I think it would be cool to have a note in the release note that something can go sideways with |
This reverts commit e1d6e28.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are there any plans to support newer setuptools? A lot of other packages require setuptools 60+, making it difficult to build multiple packages from source. |
@adamjstewart Yea, I think it's safe to raise the upper bound for |
Fixes wheel building scipy 1.7.3 no longer has manylinux1 wheels on pypi. Either we restrict the scipy version for building or we remove
manylinux
.