Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base sample-prop implementation and docs (alternative to #21284) #22083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base sample-prop implementation and docs (alternative to #21284) #22083
Changes from all commits
dbead5c
7868950
5793318
6696497
c0841c8
1aff2eb
1457293
af86e82
4c228cf
11649d9
b5c962c
fb200e2
6f849b2
82b2128
6f3f590
16c47b2
1c591fe
93d448e
167e4c2
3d199ee
20fe48a
39a462d
bd5ae36
79b43f1
515d00c
01c942a
346532d
e2adff0
98af496
93f0698
93e7b5e
3426d54
d07f949
b0cfdd5
6d3942f
6b3c2d1
9f0741e
e2c9376
c99b340
0ad69f2
c4eb53e
16fc971
19da9f7
1adc00b
13dc2ff
f8e5005
6f54e2c
32c7a52
1bfe7ae
4c5ebfc
227e727
8f6dbd7
c834ba3
4d067d1
4fc1ac1
59b779e
4da93c6
27ba25c
78de01c
2f03a1b
ada1b69
6df8049
d52f2f6
4d908e3
3bfe856
5fb9366
c259c93
c278696
3ebbf69
d75a803
beb2544
ad63680
71e79df
5871e50
e3f897c
c380ad7
bae8402
8ca978b
1aed83c
5fda075
7663cfe
2f51480
d87cbc2
46dccf2
e5d46e3
70f8c6c
560a2da
e932501
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a glossary entry for
metadata consumer
,metadata router
andmetadata request
based on sme of this text?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this seems to be over-complicated, in the sense that a consumer is just an estimator that can make use of some metadata, and a router is just a SLEP006-compliant estimator that calls a method or function which accepts metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to simplify the text AND be accurate: e.g. a consumer is not just an estimator. It can be any other object which is used in the router.
I think we can add the glossary entries once we're set on these definitions.