Skip to content

DOC Update documentation of weight boosting estimators w/ranges #22097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2021
Merged

DOC Update documentation of weight boosting estimators w/ranges #22097

merged 1 commit into from
Dec 31, 2021

Conversation

genvalen
Copy link
Contributor

@genvalen genvalen commented Dec 30, 2021 •
edited
Loading

Reference Issues/PRs

References #21605

What does this implement/fix? Explain your changes.

Update AdaBoostClassifier and AdaBoostRegressor scalar parameter documentation to include the expected range.

Any other comments?

ogrisel
ogrisel approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thomasjpfan thomasjpfan changed the title [MRG] DOC Update documentation of weight boosting estimators with accepted range of scalar parameters DOC Update documentation of weight boosting estimators with accepted range of scalar parameters Dec 31, 2021
thomasjpfan
thomasjpfan approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Update documentation of weight boosting estimators with accepted range of scalar parameters DOC Update documentation of weight boosting estimators w/ranges Dec 31, 2021
@thomasjpfan thomasjpfan merged commit 3262783 into scikit-learn:main Dec 31, 2021
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
@genvalen @venkyyuvy
DOC Update documentation of weight boosting estimators w/ranges (scik…
2073d41 
…it-learn#22097)
@genvalen genvalen deleted the weight_boosting_add_param_range_to_docs branch January 4, 2022 16:50
@genvalen genvalen mentioned this pull request Jan 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genvalen @ogrisel @thomasjpfan