Skip to content

ENH Adds get_feature_names_out for discriminant_analysis #22120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2022
Merged

ENH Adds get_feature_names_out for discriminant_analysis #22120

merged 2 commits into from
Jan 4, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Address a part of #21308

What does this implement/fix? Explain your changes.

This PR add get_feature_names_out to discriminant_analysis estimators.

@thomasjpfan thomasjpfan mentioned this pull request Jan 3, 2022
Closed
14 tasks
ogrisel
ogrisel approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glemaitre glemaitre merged commit 5c67518 into scikit-learn:main Jan 4, 2022
@glemaitre
Copy link
Member

Thanks @thomasjpfan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @glemaitre @ogrisel