Skip to content

DOC Ensures that nan_euclidean_distances passes numpydoc #22140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2022
Merged

DOC Ensures that nan_euclidean_distances passes numpydoc #22140

merged 4 commits into from
Jan 10, 2022

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented Jan 7, 2022 •
edited
Loading

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Brings sklearn.metrics.pairwise.nan_euclidean_distances documentation into numpydoc compliance

Any other comments?

N/A

thomasjpfan
thomasjpfan reviewed Jan 7, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Micky774 !

thomasjpfan
thomasjpfan reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Edit: Linting errors can be found here

thomasjpfan
thomasjpfan approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics.pairwise.nan_euclidean_distances passes numpydoc validation DOC Ensures that nan_euclidean_distances passes numpydoc Jan 10, 2022
@thomasjpfan thomasjpfan merged commit a990fc8 into scikit-learn:main Jan 10, 2022
This was referenced Jan 10, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Micky774 @thomasjpfan