-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
ENH Adds get_feature_names to isotonic module #22249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Adds get_feature_names to isotonic module #22249
Conversation
Seems fine. Is there a reason why you don't use the |
I wanted to adjust the docstring for The alternative is to add support for
|
Thanks for the clarification. I don't really know what we should expect in the 1d case either. Maybe it's better to stick to your current workaround for now and come back to implementing n_features_in_ when we have a clear expectation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe add a comment on top of get_feature_names_out
to quickly explain the need for re-implementing it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reference Issues/PRs
Towards #21308
What does this implement/fix? Explain your changes.
IsotonicRegression
only supports 2d arrays with 1 feature and 1d arrays. In this case, I think we can haveget_feature_names_out
always return "isotonicregression0".Any other comments?
Note that the common tests does not run on
IsotonicRegression
because it has the{"X_types": ["1darray"]}
tag.