Skip to content

ENH Adds get_feature_names to cluster module #22255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2022
Merged

ENH Adds get_feature_names to cluster module #22255

merged 3 commits into from
Jan 28, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Towards #21308

What does this implement/fix? Explain your changes.

Adds get_feature_names_out to cluster module.

@thomasjpfan thomasjpfan mentioned this pull request Jan 20, 2022
Closed
14 tasks
ogrisel
ogrisel approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jeremiedbb
jeremiedbb approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @thomasjpfan

@jeremiedbb jeremiedbb merged commit 5219b6f into scikit-learn:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @jeremiedbb