ENH Replaced RandomState.rand with equivalent uniform #22327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasjpfan Follow up to the prior PR |
|
@jeremiedbb In case you'd be interested in taking a look at this one as well |
|
For future reference, the open message should say that changing from Also it's good to link to the original issue. (I think it should be #16988) |
RandomState.rand with equivalent Generator-compatible RandomState.uniform calls
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
A follow-up to #22271
Addresses #16988
What does this implement/fix? Explain your changes.
Replaced
RandomState.randwith equivalent Generator-compatibleRandomState.uniformcallsAny other comments?
Note that this is a non-functional change -- all behaviour should be maintained. This is a syntax/structural change which prepares for any eventual shift from
RandomState-->Generatorobjects. See here for further details.