Skip to content

TST Complete test for pairwise_distance_{argmin,argmin_min} #22371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2022
Merged

TST Complete test for pairwise_distance_{argmin,argmin_min} #22371

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9a8723
TST Complete tests for pairwise_distance_{argmin,argmin_min}
jjerphan Feb 4, 2022
f6caee0
CLN Address review comments
jjerphan Feb 4, 2022
6679d86
Use appropriate function to test
jjerphan Feb 8, 2022
08476fa
Merge branch 'main' into tst/pairwise_distances_argmin_min-axis
jjerphan Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions sklearn/metrics/tests/test_pairwise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,30 @@ def test_pairwise_distances_argmin_min():
np.testing.assert_almost_equal(dist_orig_ind, dist_chunked_ind, decimal=7)
np.testing.assert_almost_equal(dist_orig_val, dist_chunked_val, decimal=7)

# Changing the axis and permuting datasets must give the same results
argmin_0, dist_0 = pairwise_distances_argmin_min(X, Y, axis=0)
argmin_1, dist_1 = pairwise_distances_argmin_min(Y, X, axis=1)

assert_allclose(dist_0, dist_1)
assert_array_equal(argmin_0, argmin_1)

argmin_0, dist_0 = pairwise_distances_argmin_min(X, X, axis=0)
argmin_1, dist_1 = pairwise_distances_argmin_min(X, X, axis=1)

assert_allclose(dist_0, dist_1)
assert_array_equal(argmin_0, argmin_1)

# Changing the axis and permuting datasets must give the same results
argmin_0 = pairwise_distances_argmin(X, Y, axis=0)
argmin_1 = pairwise_distances_argmin(Y, X, axis=1)

assert_array_equal(argmin_0, argmin_1)

argmin_0 = pairwise_distances_argmin(X, X, axis=0)
argmin_1 = pairwise_distances_argmin(X, X, axis=1)

assert_array_equal(argmin_0, argmin_1)


def _reduce_func(dist, start):
return dist[:, :100]
Expand Down