[WIP] Preprocessing refactoring #2252
Conversation
|
|
||
| def _check_transform_selected(X, X_expected, sel): | ||
| for M in (X, sparse.csr_matrix(X)): | ||
| Xtr = _transform_selected(M, Binarizer().transform, sel) |
There was a problem hiding this comment.
_transform_selected is in preprocessing.label and is tested with Binarizer from preprocessing.data, is it ok?
|
I updated the title, it was a bit misleading ;) |
| # Authors: Alexandre Gramfort <alexandre.gramfort@inria.fr> | ||
| # Mathieu Blondel <mathieu@mblondel.org> | ||
| # Olivier Grisel <olivier.grisel@ensta.org> | ||
| # Andreas Mueller <amueller@ais.uni-bonn.de> |
There was a problem hiding this comment.
How should I split the authors?
There was a problem hiding this comment.
When in doubt I would put all authors on all files. Though I have no recollection of doing anything in this module ^^
There was a problem hiding this comment.
Ok, that's what I did
|
Thanks :-) |
|
I think I would have git-moved the |
| return np.hstack((X_sel, X_not_sel)) | ||
|
|
||
|
|
||
| class OneHotEncoder(BaseEstimator, TransformerMixin): |
|
did you run pyflake to check for unused imports? |
|
Done. But I pulled master and I got a "Merge" commit... |
|
don't worry about it. |
|
Take care of the possible modification due to #2251. |
|
So far, it looks good but I haven't look in detail. |
|
merged by rebase. thanks :) |
Fix issue #2238