There is a downside to this PR. If we are updating the contributing docs in a PR, then the navbar built by the CI would not link to changes in the PR. (It would always link to https://scikit-learn.org/dev/developers/index.html)

There is a downside to this PR. If we are updating the contributing docs in a PR, then the navbar built by the CI would not link to changes in the PR. (It would always link to https://scikit-learn.org/dev/developers/index.html)

The website is updated daily, right?

EDIT: sorry I realize now what you mean. But the new rendering for the modified page will be build anyway, right?

But the new rendering for the modified page will be build anyway, right?

Yup, everything is still built.

I updated the PR with a workaround:

1. The navbar links to the newly built development page for dev releases, which applies to PRs or main.
2. On release builds, such as on 1.0.X, the link changes to https://scikit-learn.org/dev/developers/index.html

@thomasjpfan I just realized that there is another link to the contributing guide in the homepage

On release builds, such as on 1.0.X, the link changes to https://scikit-learn.org/dev/developers/index.html

Are we fine with showing the following warning?

Are we fine with showing the following warning?

If we are linking out of https://scikit-learn.org/stable into https://scikit-learn.org/dev then we need to still show it.

The UX issue when one navigates to the Development which links out to "dev" but then wants to look at the current API docs. The only way to do it is to go back, since the navbar is the dev page.

I'm not completely happy with this solution and it's a compromise.

Here are more alternative:

1. A banner on the top of the stable "Contributing" and "Development" pages that says "For the latest development workflow see the [link to dev page]"
2. Have "Development" open a new tab so one only needs to close the tab to get back to the stable page.

I updated the PR to open a new page when clicking on `Contributing" or "Development". I think this is common practice since we are linking off from the stable website to the dev website.

Note: On dev builds or PRs, we still link to the actual page. The linking off to the dev website only happens on stable builds.

@thomasjpfan, from the artifacts the link opens a new page. Is it expected ?

from the artifacts the link opens a new page. Is it expected ?

It's a bug. It should not open a new page. PR updated with 86fde2d (#22550) with a fix.

Hum actually I don't think it can be tested from the artifacts since they build the dev version. At least it allows to check that the links on the dev version doesn't open a new page.

Edit: I misread my own comment. Ignore this :)