Skip to content

CI: remove special case for scikit-image install #22564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Feb 21, 2022

This was done in #18761 because scikit-image did not provide wheels for Python 3.9 at the time. This is very likely not needed anymore but the CI run will tell us.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Feb 21, 2022
@lesteve lesteve changed the title MAINT: remove special case for scikit-image install CI: remove special case for scikit-image install Feb 21, 2022
@jeremiedbb
Copy link
Member

Since it runs against latest dependencies, it'll probably break again at some point. Wouldn't it be safer to keep preventing to build from source and do that even for the other optional deps instead ?

@lesteve
Copy link
Member Author

lesteve commented Feb 21, 2022

Yes, I managed to lure you with the "Quick review" label 😉 (or maybe it was pure coincidence ...)

Since it runs against latest dependencies, it'll probably break again at some point.

It only breaks if there is a release without wheels, do we expect that to happen often?

My plan going forward is to move towards lock files, see #22448, in other words for this particular build, dependencies will be pinned with the maximum version updated automatically in a PR (by hand first, automatically with Github Action eventually).

@jeremiedbb
Copy link
Member

Yes, I managed to lure you with the "Quick review" label

Totally :D

dependencies will be pinned with the maximum version

for which there are available wheels ?

@lesteve
Copy link
Member Author

lesteve commented Feb 21, 2022

for which there are available wheels ?

I think this is doable with pip-compile, there is a --pip-args argument to pass additional arguments to pip so you could pass --only-binary to it.

For conda-lock I am not too sure you can have this logic in environment.yml somehow or pass it to poetry since poetry is used for the pip dependencies inside the environment.yml (edit: it does not seem that easy to do after googling).

@jeremiedbb
Copy link
Member

This change is included in #22567 which will get merged almost surely. Should this one be closed ?

@lesteve
Copy link
Member Author

lesteve commented Feb 22, 2022

Indeed that was not part of my evil plan I promise ... closing this one then ...

@lesteve
Copy link
Member Author

lesteve commented Feb 22, 2022

I'll keep in mind your proposal of trying as much as possible to install wheels with pip if my lock files work #22448

@lesteve lesteve closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants