DOC Clarifies comments and docstrings in _BaseDiscreteNB #22565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 22, 2022
thomasjpfan
reviewed
Feb 22, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
reviewed
Feb 22, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Feb 23, 2022
|
@thomasjpfan @jeremiedbb Thank you for reviewing. Please see the next one if you are still in the context: PR #22596 |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
…n#22565) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
As far as I know, there was no issue for that. I briefly mentioned what I had on my mind in #22502, where @glemaitre gave me a general guidance, which I am trying to follow.
What does this implement/fix? Explain your changes.
All changes are private.
_BaseNB._joint_log_likelihoodis corrected: I included a detail, which is important for implementation of a naive Bayes meta-estimators I am working on now (PR is coming within a day or so). I don't think this docstring appears in the documentation.Abstract methodsAbstract methods will be added in a separated PR._countand_update_feature_log_probare added to the abstract class_BaseDiscreteNB, along with a minimal description of what these methods should do. I believe this addition will facilitate understanding and maintaining the code. Currently, the abstract methods aren't mentioned anywhere, but are called and their effects are expected by concrete methods of the same class.Any other comments?
None.