Skip to content

FIX Avoid side effects importing pip/setuptool in show_version #22621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2022
Merged

FIX Avoid side effects importing pip/setuptool in show_version #22621

merged 2 commits into from
Feb 28, 2022

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Feb 26, 2022

Fixes #22614.
Requires dropping Python 3.7 support first: #22617.

@ogrisel ogrisel mentioned this pull request Feb 26, 2022
Closed
@ogrisel
Copy link
Member Author

ogrisel commented Feb 26, 2022

I checked that all the CI failures are ModuleNotFoundError: No module named 'importlib.metadata' which will go away once we merge #22617.

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Feb 26, 2022
jeremiedbb
jeremiedbb approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomasjpfan
thomasjpfan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title FIX avoid side effect of importing pip/setuptools in show_versions() FIX Avoid side effects importing pip/setuptool in show_version Feb 28, 2022
@thomasjpfan thomasjpfan merged commit 817f069 into scikit-learn:main Feb 28, 2022
@jeremiedbb jeremiedbb mentioned this pull request Feb 28, 2022
Closed
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Mar 1, 2022
@ogrisel @jeremiedbb
FIX Avoid side effects importing pip/setuptool in show_version (sciki…
c25548a 
…t-learn#22621)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@ogrisel ogrisel deleted the use-importlib.metadata branch March 1, 2022 16:16
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@ogrisel @jeremiedbb @thomasjpfan
FIX Avoid side effects importing pip/setuptool in show_version (sciki…
0996ce0 
…t-learn#22621)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:utils Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

joblib development version breaks sklearn.show_versions()
3 participants
@ogrisel @thomasjpfan @jeremiedbb