TST use global_dtype in sklearn/cluster/tests/test_mean_shift.py #22672
+37
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Mar 3, 2022
There was a problem hiding this comment.
Thanks for the PR.
I think at least one test (probably test_mean_shift would make most sense) needs to explicitly check the impact of changing the dtype of X on the expected dtype of ms.cluster_centers_.
Intuitively I would expect ms.cluster_centers_.dtype == X.dtype unless there is a good reason to systematically upcast to np.float64, in which case it should probably be documented with an inline comment in the test and in the docstring of for the cluster_centers_ attribute.
I also realize that no test check the expected shape of ms.cluster_centers_. I think test_mean_shift should be updated to do that.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
test_mean_shift.py to test implementations on 32bit datasets
jeremiedbb
reviewed
Mar 18, 2022
Co-authored-by: Jérémie du Boisberranger <jeremiedbb@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
ogrisel
reviewed
May 16, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
approved these changes
May 16, 2022
ogrisel
reviewed
May 16, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
May 19, 2022
…kit-learn#22672) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Jérémie du Boisberranger <jeremiedbb@users.noreply.github.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #22881
Precedes #22590
What does this implement/fix? Explain your changes.
This parametrizes tests from
test_mean_shift.pyto run on 32bit datasets.Any other comments?
We could introduce a mechanism to be able to able to remove tests' execution on 32bit datasets if this takes too much time to complete.