BLD Monkeypatch windows build to stablize build #22693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that the windows build still fails from time to time: https://github.com/scikit-learn/scikit-learn/actions/runs/2002178357 I am placing this on the 1.1 milestone to stabilize the wheel builds to help when we release. |
jeremiedbb
reviewed
Mar 20, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #22310
What does this implement/fix? Explain your changes.
This PR does the same monkey patch as numpy/numpy#20640 but for older versions of NumPy.
Any other comments?
At this rate, I think we are going to release 1.1 with the
setuptoolsbuild system. I think it would be good to at least stabilize the windows build. This way we do not need to restart the entire wheel building CI because windows randomly failed.