Skip to content

ENH Add feature_names_out to voting estimators #22697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 8, 2022
Merged

ENH Add feature_names_out to voting estimators #22697

merged 6 commits into from
Mar 8, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Towards #21308

What does this implement/fix? Explain your changes.

This PR adds get_feature_names_out to voting classifiers. Note that voting='soft' and flatten_transform=False has no feature names because the transform is 3d.

@thomasjpfan thomasjpfan mentioned this pull request Mar 5, 2022
Closed
14 tasks
@thomasjpfan thomasjpfan added this to the 1.1 milestone Mar 5, 2022
ogrisel
ogrisel approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@thomasjpfan @ogrisel
Update sklearn/ensemble/tests/test_voting.py
5f2c5df 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Mar 7, 2022
jeremiedbb
jeremiedbb reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks. LGTM otherwise.

@thomasjpfan thomasjpfan force-pushed the voting_get_feature_names_out branch from 01b91d9 to 9b9d534 Compare March 8, 2022 18:52
@jeremiedbb jeremiedbb merged commit 692225d into scikit-learn:main Mar 8, 2022
@jeremiedbb
Copy link
Member

The last one ! thanks @thomasjpfan !

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@thomasjpfan @glemaitre
ENH Add feature_names_out to voting estimators (scikit-learn#22697)
03572e3
@eddiebergman eddiebergman mentioned this pull request Nov 15, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:ensemble Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @jeremiedbb @ogrisel