MAINT Refactor the common logic for GEMM in wrapper #22719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are going to introduce more and more concrete `PairwiseDistancesReduction`, this will help removing duplicated code logic. Moreover, this will also help with the upcast when templating implementations to support various dtypes.
PairwiseDistancesReduction: factor the common logic for GEMM under a wrapper
3 tasks
thomasjpfan
reviewed
Mar 7, 2022
PairwiseDistancesReduction: factor the common logic for GEMM under a wrapperPairwiseDistancesReduction: factor the common logic for GEMM in wrapper
ogrisel
approved these changes
Mar 11, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
PairwiseDistancesReduction: factor the common logic for GEMM in wrapper
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #22320.
Precedes #22590.
What does this implement/fix? Explain your changes.
As we are going to introduce more and more concrete
PairwiseDistancesReduction, the logic for the GEMM calls for the specialization is going to duplicated again and again.A component is introduced here to help removing some of the duplicated code logic for GEMM.
Moreover, this introduction will also help with the upcasting when working on the support of new dtypes as the templating will only be done on this component.
This also convert the previous buffers to
std::vectorsfor an eased memory management.