Skip to content

MNT Removes externals._pilutil and uses Pillow directly #22743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Alternative to #21166

What does this implement/fix? Explain your changes.

This PR removes the need for externals._pilutil and uses the Pillow API directly.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed this is probably more straight forward and less likely to break in the future.

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Mar 17, 2022
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesteve
Copy link
Member

lesteve commented Mar 18, 2022

Merging thanks! 2 approvals, the codecov failure is due to the fact that we likely have no build with coverage and without pillow, but that was probably the case before as well so 🤷

@lesteve lesteve merged commit a5c90f8 into scikit-learn:main Mar 18, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants