Skip to content

FEAT add metadata routing to splitters #22765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 18, 2022
Merged

FEAT add metadata routing to splitters #22765

merged 8 commits into from
Mar 18, 2022

Conversation

adrinjalali
Copy link
Member

This PR adds metadata routing to splitters.

*Group* splitters request groups as REQUESTED by default.

@adrinjalali adrinjalali added this to the 1.1 milestone Mar 11, 2022
@adrinjalali
Copy link
Member Author

ready for review @lorentzenchr @thomasjpfan @jnothman

thomasjpfan
thomasjpfan reviewed Mar 13, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up PR!

jnothman
jnothman reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I'm quite happy with this. Just waiting to see the resolution of @thomasjpfan's comments.

@adrinjalali
Copy link
Member Author

@thomasjpfan I'm not sure what I should do here now.

thomasjpfan
thomasjpfan approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about test, otherwise LGTM

jnothman
jnothman approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d also prefer if we are testing the objects not their reprs, but I know we’ve done so in the base sample props implementation

@adrinjalali
Copy link
Member Author

Merging - updated the test as requested.

@adrinjalali adrinjalali merged commit 1dc6f5f into scikit-learn:sample-props Mar 18, 2022
@adrinjalali adrinjalali deleted the slep6/split branch March 18, 2022 16:04
@adrinjalali adrinjalali mentioned this pull request Mar 18, 2022
Open
28 tasks
adrinjalali added a commit that referenced this pull request Mar 22, 2022
@adrinjalali
FEAT add metadata routing to splitters (#22765)
6a0fe13 
* FEAT add metadata routing to splitters

* forgot black

* add end of file line

* ignore mypy error

* SIMPLE_SPLITTERS -> NO_GROUP_SPLITTERS

* simplify comment

* add notes on what the tests do

* improve test and avoid using repr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:model_selection module:utils No Changelog Needed
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @jnothman @thomasjpfan