FIX Fix ColumnTransformer.get_feature_names_out with slices #22775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Mar 12, 2022
ogrisel
approved these changes
Mar 14, 2022
thomasjpfan
reviewed
Mar 14, 2022
Comment on lines
1760
to
1767
| ( | ||
| [ | ||
| ("bycol1", TransWithNames(), slice(1, 2)), | ||
| ("bycol2", "drop", ["d"]), | ||
| ], | ||
| "passthrough", | ||
| ["bycol1__b", "remainder__a", "remainder__c"], | ||
| ), |
There was a problem hiding this comment.
May we update this example to have a slice with more than one element?
(
[
("bycol1", TransWithNames(), slice(1, 3)),
],
"drop",
["bycol1__b", "bycol1__c"],
),
Comment on lines
1876
to
1881
| [ | ||
| ("bycol1", TransWithNames(), ["d", "c"]), | ||
| ("bycol2", "passthrough", slice(0, 1)), | ||
| ], | ||
| "drop", | ||
| ["d", "c", "a"], |
There was a problem hiding this comment.
Same here regarding slicing with more than one element:
Suggested change
| [ | |
| ("bycol1", TransWithNames(), ["d", "c"]), | |
| ("bycol2", "passthrough", slice(0, 1)), | |
| ], | |
| "drop", | |
| ["d", "c", "a"], | |
| [ | |
| ("bycol1", TransWithNames(), ["d", "c"]), | |
| ("bycol2", "passthrough", slice(0, 2)), | |
| ], | |
| "drop", | |
| ["d", "c", "a", "b"], |
There was a problem hiding this comment.
@ogrisel @thomasjpfan Thanks for your feedback. I have pushed another commit incorporating your suggestions. Tx
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #22774
What does this implement/fix? Explain your changes.
Currently, ColumnTransformer's get_feature_names_out does not work when the columns are specified as slices. This fix makes get_feature_names_out work properly with slices as well.
Any other comments?